Load more pipeline log lines (500 => 5000) #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to load 3500 lines without problems (it seems the browser goes from 5 MB memory usage to 10 MB). This way, we will hit the boundary less often, lowering the need to get lazy loading woodpecker-ci#2653 fixed
|
I think this should be implemented using some kind of pagination with "show more" button or something like this. |
|
If 5000 lines is displaying fast enough and not consuming too much browser memory, then I think this should be merged. |
|
well the underlaying issue still remains ... I consider this a workaround and we should revert it asap lazyloading is implemented. if we are going to merge this or on ... I leave it to the more frontend-related maintainers ;) |
6543
reviewed
Jan 18, 2024
Co-authored-by: 6543 <6543@obermui.de>
qwerty287
approved these changes
Jan 22, 2024
pat-s
pushed a commit
that referenced
this pull request
Jan 31, 2024
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[#3226](#3226)] ### 📚 Documentation - Add release types [[#3303](#3303)] - Add opencollective footer [[#3281](#3281)] - Use array syntax in docs [[#3242](#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[#3299](#3299)] - Fix agent updating [[#3287](#3287)] - Sanitize pod's step label [[#3275](#3275)] - Pipeline errors must be an array [[#3276](#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[#3265](#3265)] - fix: bug pod service without label service [[#3256](#3256)] - Fix disabling PRs [[#3258](#3258)] - fix: bug annotations [[#3255](#3255)] ### 📈 Enhancement - Update theme on system color mode change [[#3296](#3296)] - Improve secrets availability checks [[#3271](#3271)] - Load more pipeline log lines (500 => 5000) [[#3212](#3212)] - Clean up models [[#3228](#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[#3294](#3294)] - fix(deps): update docs npm deps non-major [[#3295](#3295)] - Remove deprecated `group` from config [[#3289](#3289)] - Add spellcheck config [[#3018](#3018)] - fix(deps): update golang (packages) [[#3284](#3284)] - chore(deps): lock file maintenance [[#3274](#3274)] - chore(deps): update web npm deps non-major [[#3273](#3273)] - Pin prettier version [[#3260](#3260)] - Fix prettier [[#3259](#3259)] - Update UI building in Makefile [[#3250](#3250)]
fernandrone
pushed a commit
to quintoandar/woodpecker
that referenced
this pull request
Feb 1, 2024
Co-authored-by: 6543 <6543@obermui.de>
fernandrone
pushed a commit
to quintoandar/woodpecker
that referenced
this pull request
Feb 1, 2024
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[woodpecker-ci#3226](woodpecker-ci#3226)] ### 📚 Documentation - Add release types [[woodpecker-ci#3303](woodpecker-ci#3303)] - Add opencollective footer [[woodpecker-ci#3281](woodpecker-ci#3281)] - Use array syntax in docs [[woodpecker-ci#3242](woodpecker-ci#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[woodpecker-ci#3299](woodpecker-ci#3299)] - Fix agent updating [[woodpecker-ci#3287](woodpecker-ci#3287)] - Sanitize pod's step label [[woodpecker-ci#3275](woodpecker-ci#3275)] - Pipeline errors must be an array [[woodpecker-ci#3276](woodpecker-ci#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[woodpecker-ci#3265](woodpecker-ci#3265)] - fix: bug pod service without label service [[woodpecker-ci#3256](woodpecker-ci#3256)] - Fix disabling PRs [[woodpecker-ci#3258](woodpecker-ci#3258)] - fix: bug annotations [[woodpecker-ci#3255](woodpecker-ci#3255)] ### 📈 Enhancement - Update theme on system color mode change [[woodpecker-ci#3296](woodpecker-ci#3296)] - Improve secrets availability checks [[woodpecker-ci#3271](woodpecker-ci#3271)] - Load more pipeline log lines (500 => 5000) [[woodpecker-ci#3212](woodpecker-ci#3212)] - Clean up models [[woodpecker-ci#3228](woodpecker-ci#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[woodpecker-ci#3294](woodpecker-ci#3294)] - fix(deps): update docs npm deps non-major [[woodpecker-ci#3295](woodpecker-ci#3295)] - Remove deprecated `group` from config [[woodpecker-ci#3289](woodpecker-ci#3289)] - Add spellcheck config [[woodpecker-ci#3018](woodpecker-ci#3018)] - fix(deps): update golang (packages) [[woodpecker-ci#3284](woodpecker-ci#3284)] - chore(deps): lock file maintenance [[woodpecker-ci#3274](woodpecker-ci#3274)] - chore(deps): update web npm deps non-major [[woodpecker-ci#3273](woodpecker-ci#3273)] - Pin prettier version [[woodpecker-ci#3260](woodpecker-ci#3260)] - Fix prettier [[woodpecker-ci#3259](woodpecker-ci#3259)] - Update UI building in Makefile [[woodpecker-ci#3250](woodpecker-ci#3250)]
quotengrote
pushed a commit
to quotengrote/ansible
that referenced
this pull request
Feb 1, 2024
….0 (#707) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-server](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-server)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@​anbraten](https://github.com/anbraten), [@​HerHde](https://github.com/HerHde), [@​qwerty287](https://github.com/qwerty287), [@​pat-s](https://github.com/pat-s), [@​renovate](https://github.com/renovate)\[bot], [@​lukashass](https://github.com/lukashass), [@​zc-devs](https://github.com/zc-devs), [@​Alonsohhl](https://github.com/Alonsohhl), [@​healdropper](https://github.com/healdropper), [@​eliasscosta](https://github.com/eliasscosta), [@​runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#​3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#​3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#​3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#​3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#​3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#​3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#​3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#​3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#​3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#​3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#​3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#​3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#​3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#​3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#​3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#​3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#​3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#​3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#​3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#​3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#​3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#​3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#​3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#​3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#​3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#​3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/707 Co-authored-by: Renovate Bot <renovate@mgrote.net> Co-committed-by: Renovate Bot <renovate@mgrote.net>
quotengrote
pushed a commit
to quotengrote/ansible
that referenced
this pull request
Feb 1, 2024
…0 (#706) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-agent](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-agent)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@​anbraten](https://github.com/anbraten), [@​HerHde](https://github.com/HerHde), [@​qwerty287](https://github.com/qwerty287), [@​pat-s](https://github.com/pat-s), [@​renovate](https://github.com/renovate)\[bot], [@​lukashass](https://github.com/lukashass), [@​zc-devs](https://github.com/zc-devs), [@​Alonsohhl](https://github.com/Alonsohhl), [@​healdropper](https://github.com/healdropper), [@​eliasscosta](https://github.com/eliasscosta), [@​runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#​3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#​3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#​3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#​3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#​3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#​3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#​3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#​3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#​3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#​3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#​3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#​3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#​3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#​3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#​3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#​3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#​3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#​3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#​3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#​3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#​3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#​3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#​3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#​3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#​3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#​3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/706 Co-authored-by: Renovate Bot <renovate@mgrote.net> Co-committed-by: Renovate Bot <renovate@mgrote.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to load 3500 lines without problems (it seems the browser goes from 5 MB memory usage to 10 MB).
This way, we will hit the boundary less often, lowering the need to get lazy loading #2653 fixed